-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 274: Add continuous benchmark structure #298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks a really good move. |
seabbs
commented
Jun 19, 2024
This now works i think but needs testing from main. As it doesn't touch any other code going to merge based on previous partial review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #274.
It adds infrastructure for benchmarking using
BenchmarkTools
,BenchmarkCI
, andPkgBenchmark
. I have also added proposed structure for future benchmarks but this is not set in stone. When I originally looked at this I kind of wanted to integrate this withTestItemRunner
(and so use out test suite for benchmarks) but I couldn't work out how to do this and also potentially it is better to have more targetted benchmarks?The action CI for this should:
BenchmarkCI
doesn't appear to support a build matrix hence this decision (plus saving compute). This means we won't catch platform-specific performance regressions.This could potentially get a bit noisy/slow so may need to watch how this is working out and go from there.
This can be tested locally in the
benchmark
environment using:You should also be able to use
BenchmarkCI
locally to compare commits but I haven't tested this.Note
This PR does not add an actual benchmark suite. I don't really have a great handle on
BenchmarkTools
yet and I think this should probably be done in a few issues once we have an idea of the sorts things we want to benchmark (to discuss here). Initially I would propose doing an issue per submodule and benchmarking each generative model + a few combinations and then also have a few integrated models that we benchmark in more detail (in another module/issue?).